Improve match applications

src/mainwindow.cpp

@@ -120,7 +120,7 @@ QRect MainWindow::windowRect() const
     iconSize += iconSize * 0.1;
     int length = appCount * iconSize;
 
-    if (length > maxLength) {
+    if (length >= maxLength) {
         iconSize = (maxLength - (maxLength % appCount)) / appCount;
         length = appCount * iconSize;
     }

src/utils.cpp

@@ -46,49 +46,71 @@ Utils::Utils(QObject *parent)
 
 }
 
-QString Utils::cmdFromPid(quint32 pid)
+QStringList Utils::commandFromPid(quint32 pid)
 {
     QFile file(QString("/proc/%1/cmdline").arg(pid));
-    if (!file.open(QIODevice::ReadOnly | QIODevice::Text))
-        return QString();
 
-    QString cmd = QString::fromUtf8(file.readAll());
+    if (file.open(QIODevice::ReadOnly)) {
-    QString bin;
+        QByteArray cmd = file.readAll();
 
-    for (int i = 0; i < cmd.size(); ++i) {
+        // ref: https://github.com/KDE/kcoreaddons/blob/230c98aa7e01f9e36a9c2776f3633182e6778002/src/lib/util/kprocesslist_unix.cpp#L137
-        const QChar ch = cmd[i];
+        if (!cmd.isEmpty()) {
-        if (ch == '\\')
+            // extract non-truncated name from cmdline
-            i++;
+            int zeroIndex = cmd.indexOf('\0');
-        else if (ch == ' ')
+            int processNameStart = cmd.lastIndexOf('/', zeroIndex);
-            break;
+            if (processNameStart == -1) {
-        else
+                processNameStart = 0;
-            bin += ch;
+            } else {
+                processNameStart++;
             }
 
-    if (bin.split("/").last() == "electron")
+            QString name = QString::fromLocal8Bit(cmd.mid(processNameStart, zeroIndex - processNameStart));
-        return QString();
 
-    if (bin.startsWith("/"))
+            // reion: Remove parameters
-        return bin.split("/").last();
+            name = name.split(' ').first();
 
-    return bin;
+            cmd.replace('\0', ' ');
+            QString command = QString::fromLocal8Bit(cmd).trimmed();
+
+            // There may be parameters.
+            if (command.split(' ').size() > 1) {
+                command = command.split(' ').first();
+            }
+
+            return { command, name };
+        }
+    }
+
+    return QStringList();
 }
 
 QString Utils::desktopPathFromMetadata(const QString &appId, quint32 pid, const QString &xWindowWMClassName)
 {
+    QStringList commands = commandFromPid(pid);
+
+    // The value returned from the commandFromPid() may be empty.
+    // Calling first() and last() below will cause the statusbar to crash.
+    if (commands.isEmpty() || xWindowWMClassName.isEmpty())
+        return "";
+
+    QString command = commands.first();
+    QString commandName = commands.last();
+
+    if (command.isEmpty())
+        return "";
+
     QString result;
 
     if (!appId.isEmpty() && !xWindowWMClassName.isEmpty()) {
         for (SystemAppItem *item : m_sysAppMonitor->applications()) {
             // Start search.
             const QFileInfo desktopFileInfo(item->path);
-            const QString cmdline = cmdFromPid(pid);
 
             bool founded = false;
 
-            if (desktopFileInfo.baseName() == xWindowWMClassName ||
+            if (item->exec == command || item->exec == commandName) {
-                desktopFileInfo.completeBaseName() == xWindowWMClassName)
                 founded = true;
+            }
 
             // StartupWMClass=STRING
             // If true, it is KNOWN that the application will map at least one
@@ -102,11 +124,11 @@ QString Utils::desktopPathFromMetadata(const QString &appId, quint32 pid, const
                 founded = true;
 
             // Icon name and cmdline.
-            if (!founded && item->iconName == cmdline)
+            if (!founded && (item->iconName == command || item->iconName == commandName))
                 founded = true;
 
             // Exec name and cmdline.
-            if (!founded && item->exec == cmdline)
+            if (!founded && (item->exec == command || item->exec == commandName))
                 founded = true;
 
             // Try matching mapped name against 'Name'.

src/utils.h

@@ -49,7 +49,7 @@ public:
 
     explicit Utils(QObject *parent = nullptr);
 
-    QString cmdFromPid(quint32 pid);
+    QStringList commandFromPid(quint32 pid);
     QString desktopPathFromMetadata(const QString &appId, quint32 pid = 0,
                                     const QString &xWindowWMClassName = QString());
     QMap<QString, QString> readInfoFromDesktop(const QString &desktopFile);